Update RabbitMQ client logic to use new export data format#5
Open
hhakimi53 wants to merge 3 commits into
Open
Conversation
added 2 commits
July 13, 2017 19:28
akhanzode
reviewed
Jul 19, 2017
| verifyRoutingKey(/* replicated */ true, | ||
| /* colName */ null, | ||
| /* expectedRoutingKey */ "yankeelover"); | ||
| // verifyRoutingKey(/* replicated */ true, |
Author
There was a problem hiding this comment.
If table is replicated, this test condition is not true any more. The test logic in here expected the routing key to be just table name for this case but it isn't. The behavior is same as on master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.